From: Andrew Morton <akpm@osdl.org>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] 8250: remove not needed NMI watchdog tickle in serial8250_console_write()
Date: Thu, 14 Sep 2006 21:42:10 -0700 [thread overview]
Message-ID: <20060914214210.9128e032.akpm@osdl.org> (raw)
In-Reply-To: <20060913205203.GC4787@cathedrallabs.org>
On Wed, 13 Sep 2006 17:52:03 -0300
Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org> wrote:
> When touch_nmi_watchdog() was added to inside the wait loop in
> wait_for_xmitr()[1], where the long delays come from, a unneeded
> touch_nmi_watchdog() call was left in the beginning of
> serial8250_console_write() (introduced in
> 78512ece148992a5c00c63fbf4404f3cde635016) and this patch reverts it.
>
> [1] http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/broken-out/tickle-nmi-watchdog-on-serial-output.patch
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/broken-out/tickle-nmi-watchdog-on-serial-output-fix.patch
> [2] http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78512ece148992a5c00c63fbf4404f3cde635016;hp=0ad775dbba12de3b7d25f586efe81ad995ca75a7
>
> Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
>
> --- mm.orig/drivers/serial/8250.c 2006-09-13 17:26:53.000000000 -0300
> +++ mm/drivers/serial/8250.c 2006-09-13 17:27:14.000000000 -0300
> @@ -2263,8 +2263,6 @@
> unsigned int ier;
> int locked = 1;
>
> - touch_nmi_watchdog();
> -
> local_irq_save(flags);
> if (up->port.sysrq) {
> /* serial8250_handle_port() already took the lock */
I disagree.
If characters are flowing out at a rate which consistently exceeds
one-per-ten-milliseconds, the touch_nmi_watchdog() in wait_for_xmitr() will
never be called.
Consequently a large interrupt-time write to the serial port (ie: sysrq-T
with serial-console enabled) will cause the NMI watchdog to trigger.
No?
next prev parent reply other threads:[~2006-09-15 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 20:52 Aristeu Sergio Rozanski Filho
2006-09-15 4:42 ` Andrew Morton [this message]
2006-09-15 12:03 ` Aristeu Sergio Rozanski Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060914214210.9128e032.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aris@cathedrallabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome