Re: [patch] Race condition in usermodehelper.

[Andrew Morton <akpm@osdl.org>]

On Fri, 15 Sep 2006 19:08:56 +0200
Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:

> On Fri, 2006-09-15 at 09:26 -0700, Andrew Morton wrote:
> > > [patch] Race condition in usermodehelper.
> >
> > You mean three days work?
> 
> Unfortunately yes. You really have to hit the machine hard to provoke
> this oops. All I had to work with was a dump that showed me the content
> of the memory after it crashed.

Sigh.  Sorry.

> > If so, I owe you a big apology, because an identical patch has been in -mm
> > for over a month.  I guess I didn't appreciate its significance.
> 
> Well, I could have looked in -mm after the first suspicion that there is
> something wrong with the kernel module loader. It would have saved me 2
> of the 3 days.. will remember for the next debug session.

No, you have absolutely no reason to expect that an oops fix is languishing
in -mm when we're at -rc6.  I reviewed the patch, agreed with it, queued it
in the wrong place in the series file and promptly forgot about it.  That's
literally three seconds inattention here costing three days over there.  I hate
me.

At least I got to do it to someone else for once.  But three days!!