From: Christoph Hellwig <hch@infradead.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
linux-kernel@vger.kernel.org,
Russell Cattelan <cattelan@redhat.com>,
David Teigland <teigland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
hch@infradead.org
Subject: Re: [PATCH 05/16] GFS2: File and inode operations
Date: Sat, 16 Sep 2006 14:39:47 +0100 [thread overview]
Message-ID: <20060916133947.GA1498@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0609040824290.9108@yvahk01.tjqt.qr>
>
> >+struct file gfs2_internal_file_sentinal = {
> >+ .f_flags = O_NOATIME|O_RDONLY,
> >+};
Statically allocation a struct file is not allowed. Where do you use
gfs2_internal_read? It really shouldn't be needed.
> >+static int gfs2_readdir(struct file *file, void *dirent, filldir_t filldir)
> >+{
> >+ int error;
> >+
> >+ if (strcmp(current->comm, "nfsd") != 0)
>
> Is not there a better way to do this? Note that there is also a "nfsd4" process
This is in fact not allowed at at all. Please fix you readdir code not to
need special cases for nfsd.
next prev parent reply other threads:[~2006-09-16 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 13:33 Steven Whitehouse
2006-09-04 6:52 ` Jan Engelhardt
2006-09-04 14:50 ` Steven Whitehouse
2006-09-04 14:55 ` Jan Engelhardt
2006-09-16 13:39 ` Christoph Hellwig [this message]
2006-09-18 8:27 ` Steven Whitehouse
2006-09-22 11:06 ` Steven Whitehouse
-- strict thread matches above, loose matches on Subject: below --
2006-04-21 16:13 Steven Whitehouse
2006-04-23 7:55 ` Andreas Dilger
2006-04-24 13:53 ` Steven Whitehouse
2006-04-24 22:19 ` Andreas Dilger
2006-04-25 9:27 ` Steven Whitehouse
2006-04-25 10:26 ` Christoph Hellwig
2006-04-25 11:14 ` Steven Whitehouse
2006-04-25 12:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060916133947.GA1498@infradead.org \
--to=hch@infradead.org \
--cc=cattelan@redhat.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=swhiteho@redhat.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®