From: Christoph Hellwig <hch@infradead.org>
To: Henne <henne@nachtwindheim.de>
Cc: Andrew Morton <akpm@osdl.org>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi-driver ultrastore replace Scsi_Cmnd with struct scsi_cmnd
Date: Mon, 18 Sep 2006 19:53:21 +0100 [thread overview]
Message-ID: <20060918185321.GB17670@infradead.org> (raw)
In-Reply-To: <44FE8BAC.1030004@nachtwindheim.de>
On Wed, Sep 06, 2006 at 10:49:48AM +0200, Henne wrote:
> From: Henrik Kretzschmar <henne@nachtwindheim.de>
>
> Replaces the typedef'd Scsi_Cmnd with struct scsi_cmnd.
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Looks good to me. It would be even better if you could update the
driver to not require
#include "scsi.h"
anymore and get rid of ultrastor.h. Also your mailer unfortunately
damages tabs.
next prev parent reply other threads:[~2006-09-18 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 8:49 Henne
2006-09-18 18:53 ` Christoph Hellwig [this message]
2006-09-20 9:57 ` Henne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918185321.GB17670@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=henne@nachtwindheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®