From: Konrad Rzeszutek <konradr@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alexisb@us.ibm.com
Subject: Re: [PATCH] aic94xx: Compile problem on s390
Date: Mon, 18 Sep 2006 15:36:53 -0400 [thread overview]
Message-ID: <20060918193653.GB11112@krzeszut.users.redhat.com> (raw)
In-Reply-To: <20060918192138.GR2585@parisc-linux.org>
On Mon, Sep 18, 2006 at 01:21:38PM -0600, Matthew Wilcox wrote:
> On Mon, Sep 18, 2006 at 03:15:45PM -0400, Konrad Rzeszutek wrote:
> > The aic94xx driver in my-scsi and aic94xx James Bottomley tree does not
> > compile on s390. Since the driver is generic, it makes sense to fix.
>
> Erm, well, I don't think there's any s390s with PCI ;-)
>
> > The patch is quite simple:
> > +#include <asm/scatterlist.h>
>
> Surely should be linux/scatterlist.h?
Hm. Most of the drivers use the <asm/...> and that is where
the struct scatterlist is defined. The linux/scatterlist.h includes
the asm/scatterlist.h.
Either one works.
--
Konrad Rzeszutek 1-(978)-392-3903 or 1-(617)-693-1718
IBM on-site partner.
prev parent reply other threads:[~2006-09-18 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-18 19:15 Konrad Rzeszutek
2006-09-18 19:21 ` Matthew Wilcox
2006-09-18 19:36 ` Konrad Rzeszutek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918193653.GB11112@krzeszut.users.redhat.com \
--to=konradr@redhat.com \
--cc=alexisb@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®