From: Dave Jones <davej@redhat.com>
To: Kylene Jo Hall <kjhall@us.ibm.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
linux-kernel <linux-kernel@vger.kernel.org>,
LSM ML <linux-security-module@vger.kernel.org>,
Dave Safford <safford@us.ibm.com>, Mimi Zohar <zohar@us.ibm.com>,
Serge Hallyn <sergeh@us.ibm.com>,
akpm@osdl.org
Subject: Re: [PATCH 4/7] SLIM: secfs patch
Date: Mon, 18 Sep 2006 16:54:12 -0400 [thread overview]
Message-ID: <20060918205412.GA2640@redhat.com> (raw)
In-Reply-To: <1158612642.16727.53.camel@localhost.localdomain>
On Mon, Sep 18, 2006 at 01:50:42PM -0700, Kylene Jo Hall wrote:
> > > This patch provides the securityfs used by SLIM.
nitpick. (I never reviewed this when it was posted, but this followup
caught my eye..)
> > > --- linux-2.6.18/security/slim/slm_secfs.c 1969-12-31 16:00:00.000000000 -0800
> > > +++ linux-2.6.17-working/security/slim/slm_secfs.c 2006-09-06 11:49:09.000000000 -0700
> > > @@ -0,0 +1,73 @@
> > > +/*
> > > + * SLIM securityfs support: debugging control files
> > > + *
> > > + * Copyright (C) 2005, 2006 IBM Corporation
> > > + * Author: Mimi Zohar <zohar@us.ibm.com>
> > > + * Kylene Hall <kjhall@us.ibm.com>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation, version 2 of the License.
> > > + */
> > > +
> > > +#include <asm/uaccess.h>
> > > +#include <linux/config.h>
You don't need to include config.h any more, kbuild does it for you.
(Might want to check the other files for the same thing).
Dave
next prev parent reply other threads:[~2006-09-18 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 17:57 Kylene Jo Hall
2006-09-18 20:30 ` Stephen Smalley
2006-09-18 20:50 ` Kylene Jo Hall
2006-09-18 20:54 ` Dave Jones [this message]
2006-09-20 16:49 ` [PATCH] slim: cleanup use of config.h Kylene Jo Hall
2006-09-20 16:49 ` [PATCH] integrity: " Kylene Jo Hall
2006-09-27 12:30 ` [PATCH 4/7] SLIM: secfs patch Stephen Smalley
-- strict thread matches above, loose matches on Subject: below --
2006-08-23 19:05 Kylene Jo Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918205412.GA2640@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@us.ibm.com \
--cc=sds@tycho.nsa.gov \
--cc=sergeh@us.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome