From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Alignment of fields in struct dentry
Date: Mon, 18 Sep 2006 23:24:23 +0200 [thread overview]
Message-ID: <20060918212423.GB6899@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <200609152244.07889.arnd@arndb.de>
On Fri, 15 September 2006 22:44:07 +0200, Arnd Bergmann wrote:
> Am Friday 15 September 2006 12:27 schrieb Jörn Engel:
> > -};
> > +}__attribute__((aligned(64))); /* make sure the dentry is 128/192 bytes
> > + on 32/64 bit independently of config
> > + options. d_iname will vary in length
> > + a bit. */
Wow. Mutt really didn't like quoting this.
> I'd guess that a 32 byte alignment is much better here, 64 byte sounds
> excessive. It should have the same effect with the current dentry layout
> and default config options, but would keep the d_iname length in the
> 16-44 byte range instead of 16-76 byte as your patch does.
>
> Since all important fields are supposed to be kept in 32 bytes anyway,
> they are still either at the start or the end of a given cache line,
> but never cross two.
Another take would be to use a cacheline. But I guess the difference
between 32/64/cacheline is mostly academic, given the rate of changes
to struct dentry.
Unless the minimum length for inline names is configurable, as in the
patch below. (Note to self: I really should finish my test setup
before posting any further patches without performance numbers.)
Jörn
--
Don't worry about people stealing your ideas. If your ideas are any good,
you'll have to ram them down people's throats.
-- Howard Aiken quoted by Ken Iverson quoted by Jim Horning quoted by
Raph Levien, 1979
--- slab/include/linux/dcache.h~dentry_size 2006-09-14 22:19:51.000000000 +0200
+++ slab/include/linux/dcache.h 2006-09-18 23:22:44.000000000 +0200
@@ -77,8 +77,6 @@ full_name_hash(const unsigned char *name
struct dcookie_struct;
-#define DNAME_INLINE_LEN_MIN 36
-
struct dentry {
atomic_t d_count;
unsigned int d_flags; /* protected by d_lock */
@@ -111,8 +109,8 @@ struct dentry {
struct dcookie_struct *d_cookie; /* cookie, if any */
#endif
int d_mounted;
- unsigned char d_iname[DNAME_INLINE_LEN_MIN]; /* small names */
-};
+ unsigned char d_iname[CONFIG_DCACHE_INLINE_LEN]; /* small names */
+}__cacheline_aligned;
/*
* dentry->d_lock spinlock nesting subclasses:
--- slab/fs/Kconfig~dentry_size 2006-08-11 13:03:43.000000000 +0200
+++ slab/fs/Kconfig 2006-09-18 23:22:44.000000000 +0200
@@ -1931,5 +1931,18 @@ endmenu
source "fs/nls/Kconfig"
+config DCACHE_INLINE_LEN
+ int "Length of inline filenames"
+ depends on EXPERIMENTAL
+ default 20
+ help
+ Filenames up to this length are stored inline in a struct dentry.
+ For most people something short like 20 is ok. Developers with
+ extensive use of git or ccache may want to set this to 38 or 44,
+ respectively, as those programs create and often access thousands
+ of files of that length.
+
+ If unsure, choose 20.
+
endmenu
next prev parent reply other threads:[~2006-09-18 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 9:31 Jörn Engel
2006-09-14 10:50 ` Jörn Engel
2006-09-14 18:33 ` Andreas Dilger
2006-09-14 21:02 ` Jörn Engel
2006-09-14 21:55 ` Andreas Dilger
2006-09-15 10:27 ` Jörn Engel
2006-09-15 13:41 ` Jörn Engel
2006-09-15 20:44 ` Arnd Bergmann
2006-09-18 21:24 ` Jörn Engel [this message]
2006-09-18 21:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060918212423.GB6899@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®