From: Andrew Morton <akpm@osdl.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ayaz Abdulla <aabdulla@nvidia.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>, Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] forcedeth: hardirq lockdep warning
Date: Tue, 19 Sep 2006 11:14:48 -0700 [thread overview]
Message-ID: <20060919111448.9274c699.akpm@osdl.org> (raw)
In-Reply-To: <1158670522.3278.13.camel@taijtu>
On Tue, 19 Sep 2006 14:55:22 +0200
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
I wonder what line that was. DEBUG_LOCKS_WARN_ON(current->hardirq_context),
I suppose.
> Call Trace:
> show_trace
> dump_stack
> trace_hardirqs_on
> :forcedeth:nv_nic_irq_other
> handle_IRQ_event
> __do_IRQ
> do_IRQ
> ret_from_intr
> DWARF2 barf
It's good, isn't it?
> default_idle
> cpu_idle
> rest_init
> start_kernel
> _sinittext
>
> These 3 functions nv_nic_irq_tx(), nv_nic_irq_rx() and nv_nic_irq_other()
> are reachable from IRQ context and process context.
That's "fix deadlock", not "fix lockdep warning". However it's often the
case that it's not really deadlockable because (often) the card's IRQ line
has been disabled. That appears to be the case in nv_do_nic_poll()'s call
to nv_nic_irq_tx, for example.
> Make use of the
> irq-save/restore spinlock variant.
So this perhaps is another lockdep workaround..
next prev parent reply other threads:[~2006-09-19 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 12:55 Peter Zijlstra
2006-09-19 18:14 ` Andrew Morton [this message]
2006-09-19 18:28 ` Dave Jones
2006-09-19 19:12 ` Peter Zijlstra
2006-09-20 1:04 ` Arjan van de Ven
2006-10-05 10:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060919111448.9274c699.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aabdulla@nvidia.com \
--cc=arjan@linux.intel.com \
--cc=davej@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®