From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Reiner Herrmann <reiner@reiner-h.de>
Cc: adaplas@pol.net, kernel-janitors@lists.osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation fixes in intel810.txt
Date: Wed, 20 Sep 2006 17:13:19 -0700 [thread overview]
Message-ID: <20060920171319.adb5fc5a.rdunlap@xenotime.net> (raw)
In-Reply-To: <200609210132.54818.reiner@reiner-h.de>
On Thu, 21 Sep 2006 01:32:54 +0200 Reiner Herrmann wrote:
> > >
> > > - g. "hsync1/hsync2:<value>"
> > > - select the minimum and maximum Horizontal Sync Frequency of the
> > > - monitor in KHz. If a using a fixed frequency monitor, hsync1 must
> > > + g. "hsync1/hsync2:<value>"
> > > + select the minimum and maximum Horizontal Sync Frequency of the
> > > + monitor in kHz. If using a fixed frequency monitor, hsync1 must
> >
> > Why small 'k'? Is that some standard?
> > I prefer KHz but I'm flexible.
>
> Those prefixes are case-sensitive (i.e. m = milli and M = Mega).
> The abbreviation for kilo is a lowercase k.
Yep, unfortunately. so there goes history. oh well. :)
> So here is a corrected version of the patch (with some more fixes I just detected).
one small comment below.
> Signed-off-by: Reiner Herrmann <reiner@reiner-h.de>
> ---
> diff -uprN -X linux-2.6.18/Documentation/dontdiff linux-2.6.18/Documentation/fb/intel810.txt linux-work/Documentation/fb/intel810.txt
> --- linux-2.6.18/Documentation/fb/intel810.txt 2006-09-20 05:42:06.000000000 +0200
> +++ linux-work/Documentation/fb/intel810.txt 2006-09-21 01:30:37.000000000 +0200
> - i. "voffset:<value>"
> - select at what offset in MB of the logical memory to allocate the
> + i. "voffset:<value>"
> + select at what offset in MB of the logical memory to allocate the
> framebuffer memory. The intent is to avoid the memory blocks
> used by standard graphics applications (XFree86). The default
> - offset (16 MB for a 64MB aperture, 8 MB for a 32MB aperture) will
> - avoid XFree86's usage and allows up to 7MB/15MB of framebuffer
> - memory. Depending on your usage, adjust the value up or down,
> - (0 for maximum usage, 31/63 MB for the least amount). Note, an
> + offset (16 MB for a 64MB aperture, 8 MB for a 32MB aperture) will
You could make "<number> MB" be consistent (preferably with space there).
Otherwise looks good to me. Thanks.
> + avoid XFree86's usage and allows up to 7MB/15MB of framebuffer
> + memory. Depending on your usage, adjust the value up or down,
> + (0 for maximum usage, 31/63 MB for the least amount). Note, an
> arbitrary setting may conflict with XFree86.
---
~Randy
next prev parent reply other threads:[~2006-09-21 0:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 23:03 Reiner Herrmann
2006-09-20 23:15 ` Randy.Dunlap
2006-09-20 23:32 ` Reiner Herrmann
2006-09-21 0:13 ` Randy.Dunlap [this message]
2006-09-21 0:20 ` Reiner Herrmann
2006-09-21 0:25 ` Reiner Herrmann
2006-09-21 0:58 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060920171319.adb5fc5a.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=adaplas@pol.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiner@reiner-h.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®