From: Andrew Morton <akpm@osdl.org>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>,
Michael Hanselmann <linux-kernel@hansmi.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ams: remove usage of input_dev cdev
Date: Wed, 20 Sep 2006 19:13:36 -0700 [thread overview]
Message-ID: <20060920191336.001b2c6a.akpm@osdl.org> (raw)
In-Reply-To: <200609202159.53628.dtor@insightbb.com>
On Wed, 20 Sep 2006 21:59:53 -0400
Dmitry Torokhov <dtor@insightbb.com> wrote:
> On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> > This patch removes usage of 'cdev' member of input_dev, not present
> > on that struct anymore.
> >
>
> Where did it go?
Sigh. That would make a good ./.signature
> > Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
> >
> > --- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
> > +++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
> > @@ -66,7 +66,6 @@
> > ams_info.idev->name = "Apple Motion Sensor";
> > ams_info.idev->id.bustype = ams_info.bustype;
> > ams_info.idev->id.vendor = 0;
> > - ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
> >
> > input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> > input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
> >
I think the right fix is s/cdev.dev/d.parent/g. But Greg has moved all
those patches out of the tree which I'll henceforth be merging into -mm, so
we can stop worrying about it.
prev parent reply other threads:[~2006-09-21 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 0:51 Aristeu Sergio Rozanski Filho
2006-09-21 1:59 ` Dmitry Torokhov
2006-09-21 2:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060920191336.001b2c6a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aris@cathedrallabs.org \
--cc=dtor@insightbb.com \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®