Re: GFS2 & DLM merge request

[Andrew Morton <akpm@osdl.org>]

On Fri, 22 Sep 2006 17:02:24 +0100
Steven Whitehouse <swhiteho@redhat.com> wrote:

> > >  include/linux/fs.h                 |    3 
> > >  include/linux/iflags.h             |  102 
> > >  include/linux/kernel.h             |    1 
> > >  mm/filemap.c                       |    3 
> > >  mm/readahead.c                     |    1 
> > 
> > And while we're at it, please don't push core change as part of a subsystem
> > tree ever.  They should go into clearly marked and separately patches via
> > -mm.
> 
> Ok, I'm quite happy to do that. They are pretty minor changes, but the
> usual argument is that such changes are not acceptable until there is
> something in the kernel that makes use of them, and they have to happen
> one way around or the other,

There's no 100% comfortable solution to this.  Steven presumably needs
those changes present in his tree so he can test.

What I usually suggest is that the developer get the core changes reviewed
on-list at an early stage and then explicitly flag their presence in the
covering description when sending the please-pull email.