From: Francois Romieu <romieu@fr.zoreil.com>
To: Amol Lad <amol@verismonetworks.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: ioremap balanced with iounmap for drivers/mtd subsystem
Date: Sat, 23 Sep 2006 14:43:59 +0200 [thread overview]
Message-ID: <20060923124359.GA17408@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200609222101.k8ML1oW5019174@hera.kernel.org>
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> :
> commit 25f0c659fe64832d8ee06aa623fffaad708dcf8b
[...]
> diff --git a/drivers/mtd/maps/arctic-mtd.c b/drivers/mtd/maps/arctic-mtd.c
> index d95ae58..642d96b 100644
> --- a/drivers/mtd/maps/arctic-mtd.c
> +++ b/drivers/mtd/maps/arctic-mtd.c
> @@ -96,6 +96,8 @@ static struct mtd_partition arctic_parti
> static int __init
> init_arctic_mtd(void)
> {
> + int err = 0;
Unneeded initialization.
> @@ -109,12 +111,20 @@ init_arctic_mtd(void)
> printk("%s: probing %d-bit flash bus\n", NAME, BUSWIDTH * 8);
> arctic_mtd = do_map_probe("cfi_probe", &arctic_mtd_map);
>
> - if (!arctic_mtd)
> + if (!arctic_mtd) {
> + iounmap((void *) arctic_mtd_map.virt);
Useless cast.
These two patterns are repeated all over the patch.
A grep for iounmap in drivers/mtd/nand would not hurt.
--
Ueimor
next parent reply other threads:[~2006-09-23 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200609222101.k8ML1oW5019174@hera.kernel.org>
2006-09-23 12:43 ` Francois Romieu [this message]
2006-09-25 6:49 ` [PATCH] " Amol Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060923124359.GA17408@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=amol@verismonetworks.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®