From: Tobias Klauser <tklauser@distanz.ch>
To: Amol Lad <amol@verismonetworks.com>
Cc: kernel Janitors <kernel-janitors@lists.osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] misc_register error return handling
Date: Mon, 25 Sep 2006 11:25:28 +0200 [thread overview]
Message-ID: <20060925092528.GL10725@distanz.ch> (raw)
In-Reply-To: <1159174740.25016.36.camel@amol.verismonetworks.com>
On 2006-09-25 at 10:59:00 +0200, Amol Lad <amol@verismonetworks.com> wrote:
> Ignore previous patch (mail client linewrap issue...)
>
> Some drivers do not handle failure of misc_register.
>
> Added return value checks appropriately in defaulting drivers
>
> Tested with:
> - allmodconfig
> - Manually tweaking Kconfig/Makefiles to make sure that the changed
> files compiles without any errors/warnings
>
> Signed-off-by: Amol Lad <amol@verismonetworks.com>
> ---
> arch/i386/kernel/apm.c | 23 +++++++++++++++++------
> arch/um/drivers/mmapper_kern.c | 6 ++++--
> arch/x86_64/kernel/mce.c | 6 +++++-
> drivers/char/watchdog/ep93xx_wdt.c | 4 ++++
> drivers/input/misc/hp_sdc_rtc.c | 7 ++++++-
> drivers/macintosh/apm_emu.c | 8 +++++++-
> drivers/macintosh/smu.c | 11 ++++++++---
> drivers/macintosh/via-pmu.c | 11 ++++++++---
Split up by driver/subsystem, please.
prev parent reply other threads:[~2006-09-25 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 8:59 Amol Lad
2006-09-25 9:25 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925092528.GL10725@distanz.ch \
--to=tklauser@distanz.ch \
--cc=amol@verismonetworks.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®