From: Randy Dunlap <rdunlap@xenotime.net>
To: Henne <henne@nachtwindheim.de>
Cc: Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata-piix: kerneldoc-error-on-ata_piixc.patch 2nd try
Date: Mon, 25 Sep 2006 14:23:46 -0700 [thread overview]
Message-ID: <20060925142346.cbf0ed6a.rdunlap@xenotime.net> (raw)
In-Reply-To: <45183E12.1080503@nachtwindheim.de>
On Mon, 25 Sep 2006 22:37:38 +0200 Henne wrote:
> Jeff Garzik schrieb:
> > Randy Dunlap wrote:
> >> I agree with all of these except #4. Maybe you can reconcile your
> >> preference with that in Documentation/SubmittingPatches, which
> >> contains:
> >>
> >> <quote>
> >> The canonical patch message body contains the following:
> >>
> >> - A "from" line specifying the patch author.
> >> </quote>
> >>
> >> A patch submitter should not need to know the patch receiver's
> >> personal preferences and vary patches based on those.
> >
> >
> > It's not a personal preference. It's all based on git-applymbox, pretty
> > much.
> >
> > The SubmittingPatches doc should be updated to clarify that a From line
> > is not needed in the email body, if it is the same as the From line in
> > the RFC822 header.
It seems to be a small, simple matter of "not needed" vs. "allowed".
AFAIK, From: is always allowed but it is not needed if the From: mail
header matches the From: body text.
> > Jeff
> Thanks for pointing my nose on this guys! I'll keep that in mind when writing patches, but that from line
> should be discussed by the maintainers.
---
~Randy
prev parent reply other threads:[~2006-09-25 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 18:58 Henne
2006-09-25 19:39 ` Jeff Garzik
2006-09-25 20:11 ` Randy Dunlap
2006-09-25 20:13 ` Jeff Garzik
2006-09-25 20:37 ` Henne
2006-09-25 21:23 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925142346.cbf0ed6a.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=henne@nachtwindheim.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®