From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Alexey Dobriyan" <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: hvc_iseries.c: overwriting spin_lock_irqsave()
Date: Tue, 26 Sep 2006 00:58:38 +1000 [thread overview]
Message-ID: <20060926005838.d0cd5d7e.sfr@canb.auug.org.au> (raw)
In-Reply-To: <b6fcc0a0609250547p551f49bcgab46192e7fa55a39@mail.gmail.com>
Hi Alexy,
On Mon, 25 Sep 2006 16:47:08 +0400 "Alexey Dobriyan" <adobriyan@gmail.com> wrote:
>
> Stephen, -git4 contains the following code
>
> drivers/char/hvc_iseries.c:
>
> static int put_chars(uint32_t vtermno, const char *buf, int count)
> {
> unsigned long flags;
>
> spin_lock_irqsave(&consolelock, flags);
> if (viochar_is_console(pi) && !viopath_isactive(pi->lp)) {
> spin_lock_irqsave(&consoleloglock, flags);
>
> So, old flags are lost.
Ooops! Thanks for the heads up, I will send a fix patch tomorrow.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2006-09-25 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 12:47 Alexey Dobriyan
2006-09-25 14:58 ` Stephen Rothwell [this message]
2006-09-26 1:54 ` [POWERPC] fix spin lock nesting in hvc_iseries Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060926005838.d0cd5d7e.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®