mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trident oss: Switch to newer API also fix a bug
Date: Tue, 26 Sep 2006 08:40:45 +0300	[thread overview]
Message-ID: <20060926054045.GC20797@rhun.haifa.ibm.com> (raw)
In-Reply-To: <1159224583.11049.173.camel@localhost.localdomain>

On Mon, Sep 25, 2006 at 11:49:43PM +0100, Alan Cox wrote:

> The old driver erroneously passed pdev not NULL to a second search. This
> happened to always work except with pci=reverse because of chip
> ordering.

[please CC me on trident patches]

/home/muli/kernel/trident/trident.hg/sound/oss/trident.c: In function `ali_reset_5451':
/home/muli/kernel/trident/trident.hg/sound/oss/trident.c:4128: `pdev' undeclared (first use in this function)
/home/muli/kernel/trident/trident.hg/sound/oss/trident.c:4128: (Each undeclared identifier is reported only once
/home/muli/kernel/trident/trident.hg/sound/oss/trident.c:4128: for each function it appears in.)

I'll fix it up and resubmit. Thanks for the patch!

Cheers,
Muli

      reply	other threads:[~2006-09-26  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-25 22:49 Alan Cox
2006-09-26  5:40 ` Muli Ben-Yehuda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060926054045.GC20797@rhun.haifa.ibm.com \
    --to=muli@il.ibm.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®