From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@muc.de>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Put the BUG __FILE__ and __LINE__ info out of line
Date: Thu, 28 Sep 2006 00:26:10 -0700 [thread overview]
Message-ID: <20060928002610.05e61321.akpm@osdl.org> (raw)
In-Reply-To: <20060928071731.GB84041@muc.de>
On 28 Sep 2006 09:17:31 +0200
Andi Kleen <ak@muc.de> wrote:
> > Plan #17 is to just put the BUG inline and then put the EIP+file*+line into
> > a separate section, then search that section at BUG time to find the record
> > whose EIP points back at this ud2a.
> >
> > It's a bit messy for modules, but it minimises the .text impact and keeps
> > disassembly happy, no?
> >
> > And if done right it can probably be used by other architectures.
>
>
> The way x86-64 solved it was to turn the inline code into valid
> instructions. This can be done with two additional bytes.
> IMHO that's the right solution for the problem on i386 too
>
That uses even more text.
next prev parent reply other threads:[~2006-09-28 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 6:00 Jeremy Fitzhardinge
2006-09-28 6:35 ` Andrew Morton
2006-09-28 6:49 ` Jeremy Fitzhardinge
2006-09-28 7:00 ` Andrew Morton
2006-09-28 7:17 ` Andi Kleen
2006-09-28 7:26 ` Andrew Morton [this message]
2006-09-28 10:15 ` Andi Kleen
2006-09-28 10:30 ` Jeremy Fitzhardinge
2006-09-28 10:38 ` Andi Kleen
2006-09-28 15:30 ` Hugh Dickins
2006-09-28 19:44 ` Andi Kleen
2006-09-28 10:27 ` Jeremy Fitzhardinge
2006-09-28 16:18 ` Andrew Morton
2006-09-28 16:32 ` Jeremy Fitzhardinge
2006-09-28 7:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928002610.05e61321.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome