From: Al Viro <viro@ftp.linux.org.uk>
To: J?rn Engel <joern@wohnheim.fh-wedel.de>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, holzheu@de.ibm.com
Subject: Re: [S390] hypfs sparse warnings.
Date: Thu, 28 Sep 2006 14:31:56 +0100 [thread overview]
Message-ID: <20060928133156.GG29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20060928132540.GA18933@wohnheim.fh-wedel.de>
On Thu, Sep 28, 2006 at 03:25:40PM +0200, J?rn Engel wrote:
> On Thu, 28 September 2006 15:07:37 +0200, Martin Schwidefsky wrote:
> >
> > sparse complains, if we use bitwise operations on enums. Cast enum to
> > long in order to fix that problem!
>
> At this point I start to wonder which part should be changed. Is it
> better to
> a) cast some more, as you started to do,
> b) change enums to #defines or
> c) change '|' to '+'?
>
> At any rate, you have the same problem in 5 seperate places by my
> count and only changed 1 of them. Nak - in case anyone cares.
Split enums sanely.
next prev parent reply other threads:[~2006-09-28 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 13:07 Martin Schwidefsky
2006-09-28 13:25 ` Jörn Engel
2006-09-28 13:31 ` Al Viro [this message]
2006-09-28 13:42 ` Heiko Carstens
2006-09-28 13:54 ` Jörn Engel
2006-09-28 14:21 ` Heiko Carstens
2006-09-28 14:41 ` Jörn Engel
2006-09-28 13:54 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928133156.GG29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=holzheu@de.ibm.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®