From: Sam Ravnborg <sam@ravnborg.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, mj@atrey.karlin.mff.cuni.cz,
davej@redhat.com
Subject: Re: [PATCH] x86: update vmlinux.lds.S to place .data section on a page boundary
Date: Thu, 28 Sep 2006 22:42:20 +0200 [thread overview]
Message-ID: <20060928204220.GA31096@uranus.ravnborg.org> (raw)
In-Reply-To: <20060928201249.GA10037@hmsreliant.homelinux.net>
On Thu, Sep 28, 2006 at 04:12:49PM -0400, Neil Horman wrote:
> Patch to update vmlinux linker script so that .data section is on a page
> boundary. without this change the kernel's .data section is on a non-4k
> boundary, and this prevents kexec from loading a new kernel. Tested
> successfully by me.
NAK
> + . = ALIGN(4096);
Do not use magic numbers like this.
Please replace 4096 with PAGE_SIZE - page.h is already included so it is
available.
This servers two purposes:
1) This make it more self documenting
2) It makes it more portable should we decide to do this in a general
way for all arch's.
And then maybe a comment why it is desireable to waste a lot of RAM
in some cases. For the embedded people wasting up to 4088 bytes
of RAM is not desireable.
Sam
next prev parent reply other threads:[~2006-09-28 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 20:12 Neil Horman
2006-09-28 20:42 ` Sam Ravnborg [this message]
2006-09-28 23:22 ` Neil Horman
2006-09-29 0:03 ` Neil Horman
2006-09-30 1:13 ` Eric W. Biederman
2006-10-01 21:47 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928204220.GA31096@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@atrey.karlin.mff.cuni.cz \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®