Re: [PATCH] fix EMBEDDED + SYSCTL menu

[Randy Dunlap <rdunlap@xenotime.net>]

On Fri, 29 Sep 2006 18:05:21 +0200 Adrian Bunk wrote:

> On Thu, Sep 28, 2006 at 08:42:51PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > SYSCTL should still depend on EMBEDDED.  This unbreaks the
> > EMBEDDED menu (from the recent SYSCTL_SYCALL menu option patch).
> > 
> > Fix typos in new SYSCTL_SYSCALL menu.
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  init/Kconfig |   14 +++++++-------
> >  1 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > --- linux-2618-g10.orig/init/Kconfig
> > +++ linux-2618-g10/init/Kconfig
> > @@ -257,6 +257,9 @@ config CC_OPTIMIZE_FOR_SIZE
> >  
> >  	  If unsure, say N.
> >  
> > +config SYSCTL
> > +	bool
> > +
> >  menuconfig EMBEDDED
> >  	bool "Configure standard kernel features (for small systems)"
> >  	help
> > @@ -272,11 +275,8 @@ config UID16
> >  	help
> >  	  This enables the legacy 16-bit UID syscall wrappers.
> >  
> > -config SYSCTL
> > -	bool
> > -
> 
> ACK
> 
> >  config SYSCTL_SYSCALL
> > -	bool "Sysctl syscall support"
> > +	bool "Sysctl syscall support" if EMBEDDED
> >  	default n
> >  	select SYSCTL
> >  	---help---
> >...
> 
> You could achieve the same by removing the option...
> 
> Simply move SYSCTL_SYSCALL to the same place you are moving SYSCTL to 
> without fiddling with the dependencies.

Yes, I realize that (I even had that patch earlier).
I don't care which way it's done.  Eric, any preference here?

---
~Randy