From: Randy Dunlap <rdunlap@xenotime.net>
To: Roger Gammans <roger@computer-surgery.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: fs/bio.c - Hardcoded sector size ?
Date: Fri, 29 Sep 2006 11:38:14 -0700 [thread overview]
Message-ID: <20060929113814.db87b8d5.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060928182238.GA4759@julia.computer-surgery.co.uk>
On Thu, 28 Sep 2006 19:22:38 +0100 Roger Gammans wrote:
> Hi
>
> In bio_endio() there is the follow line:-
>
> bio->bi_sector += (bytes_done >> 9);
>
> and there is a similiar line assuming a 512byte sector in
> __bio_add_page() .
>
> Is this a bug as the the actual block size should be available
> from bio->bi_bdev->bd_block_size surely - or is some clever code
> where all block devices have to translate back to 512 byte sectors
> for bio s.
Does this answer it for you?
http://marc.theaimsgroup.com/?l=linux-kernel&m=115542872706154&w=2
---
~Randy
next prev parent reply other threads:[~2006-09-29 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 18:22 Roger Gammans
2006-09-29 18:38 ` Randy Dunlap [this message]
2006-09-28 18:58 ` linux-kernel-owner
2006-09-29 19:11 ` Randy Dunlap
2006-09-28 19:19 ` Roger Gammans
2006-09-29 19:37 ` Randy Dunlap
2006-09-28 19:56 ` Roger Gammans
2006-09-29 20:17 ` Randy Dunlap
2006-09-29 20:22 ` Zach Brown
2006-09-29 20:32 ` Randy Dunlap
2006-09-29 17:25 ` Roger Gammans
2006-09-30 19:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929113814.db87b8d5.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=roger@computer-surgery.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®