From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750760AbWI3Cva (ORCPT ); Fri, 29 Sep 2006 22:51:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750757AbWI3Cva (ORCPT ); Fri, 29 Sep 2006 22:51:30 -0400 Received: from smtp.osdl.org ([65.172.181.4]:60101 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750696AbWI3Cv3 (ORCPT ); Fri, 29 Sep 2006 22:51:29 -0400 Date: Fri, 29 Sep 2006 19:47:52 -0700 From: Andrew Morton To: linas@austin.ibm.com (Linas Vepstas) Cc: jeff@garzik.org, netdev@vger.kernel.org, James K Lewis , linux-kernel@vger.kernel.org, Arnd Bergmann , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 6/6]: powerpc/cell spidernet refine locking Message-Id: <20060929194752.2194f94f.akpm@osdl.org> In-Reply-To: <20060929232911.GN6433@austin.ibm.com> References: <20060929230552.GG6433@austin.ibm.com> <20060929232911.GN6433@austin.ibm.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Sep 2006 18:29:11 -0500 linas@austin.ibm.com (Linas Vepstas) wrote: > The transmit side of the spider ethernet driver currently > places locks around some very large chunks of code. This > results in a fair amount of lock contention is some cases. > This patch makes the locks much more fine-grained, protecting > only the cirtical sections. One lock is used to protect > three locations: the queue head and tail pointers, and the > queue low-watermark location. You have spider_net_set_low_watermark() walking the tx_chain outside tx_chain.lock. Are you sure about that?