From: Andrew Morton <akpm@osdl.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: David Brownell <david-b@pacbell.net>,
Alessandro Zummo <alessandro.zummo@towertech.it>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.18-git] RTC class uses subsys_init
Date: Sun, 1 Oct 2006 02:20:22 -0700 [thread overview]
Message-ID: <20061001022022.d7f86b39.akpm@osdl.org> (raw)
In-Reply-To: <20061001090717.GA14885@aepfle.de>
On Sun, 1 Oct 2006 11:07:17 +0200
Olaf Hering <olaf@aepfle.de> wrote:
> On Thu, Sep 28, David Brownell wrote:
>
>
> > +++ linux/drivers/rtc/rtc-sysfs.c 2006-07-30 16:15:50.000000000 -0700
> > @@ -116,7 +116,7 @@
> > class_interface_unregister(&rtc_sysfs_interface);
> > }
> >
> > -module_init(rtc_sysfs_init);
> > +subsys_init(rtc_sysfs_init);
> > module_exit(rtc_sysfs_exit);
>
> subsys_init is not defined, but the change is in Linus tree now.
doh. But it still compiled.
drivers/rtc/rtc-sysfs.c:119: warning: data definition has no type or storage class
drivers/rtc/rtc-sysfs.c:119: warning: type defaults to 'int' in declaration of 'subsys_init'
drivers/rtc/rtc-sysfs.c:119: warning: parameter names (without types) in function declaration
drivers/rtc/rtc-sysfs.c:110: warning: 'rtc_sysfs_init' defined but not used
I'll fix it up.
(Wonders how it passed runtime testing..)
next prev parent reply other threads:[~2006-10-01 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 6:33 David Brownell
2006-09-30 15:44 ` Oleg Verych
2006-10-01 9:07 ` Olaf Hering
2006-10-01 9:20 ` Andrew Morton [this message]
2006-10-01 13:49 ` David Brownell
2006-10-01 20:32 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001022022.d7f86b39.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alessandro.zummo@towertech.it \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®