From: David Miller <davem@davemloft.net>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: linux/compat.h includes asm/signal.h causing problems
Date: Mon, 02 Oct 2006 13:14:14 -0700 (PDT) [thread overview]
Message-ID: <20061002.131414.74728780.davem@davemloft.net> (raw)
On some platforms, including sparc64, asm/signal.h needs
compat_sigset_t, but this is defined in linux/compat.h
after asm/signal.h is included.
Andrew, aren't you doing sparc64 cross builds these days? :-)
This came from 3f2e05e90e0846c42626e3d272454f26be34a1bc
[PATCH] BLOCK: Revert patch to hack around undeclared sigset_t in linux/compat.h
Revert Andrew Morton's patch to temporarily hack around the lack of a
declaration of sigset_t in linux/compat.h to make the block-disablement
patches build on IA64. This got accidentally pushed to Linus and should
be fixed in a different manner.
Also make linux/compat.h #include asm/signal.h to gain a definition of
sigset_t so that it can externally declare sigset_from_compat().
This has been compile-tested for i386, x86_64, ia64, mips, mips64, frv, ppc and
ppc64 and run-tested on frv.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
It figures that one of the platforms it wasn't compile tested on is
the one that breaks :-)
next reply other threads:[~2006-10-02 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 20:14 David Miller [this message]
2006-10-02 20:50 ` Andrew Morton
2006-10-02 21:04 ` David Miller
2006-10-02 21:18 ` David Miller
2006-10-03 9:45 ` David Howells
2006-10-03 10:54 ` Al Viro
2006-10-03 12:21 ` David Howells
2006-10-03 17:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002.131414.74728780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome