From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964959AbWJBXhq (ORCPT ); Mon, 2 Oct 2006 19:37:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964950AbWJBXhq (ORCPT ); Mon, 2 Oct 2006 19:37:46 -0400 Received: from smtp.osdl.org ([65.172.181.4]:28648 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964936AbWJBXhp (ORCPT ); Mon, 2 Oct 2006 19:37:45 -0400 Date: Mon, 2 Oct 2006 16:37:33 -0700 From: Andrew Morton To: "Moore, Eric" Cc: "Martin Bligh" , "LKML" , "Andy Whitcroft" , Subject: Re: Panic from mptspi_dv_renegotiate_work in 2.6.18-mm2 Message-Id: <20061002163733.610a3c1f.akpm@osdl.org> In-Reply-To: <664A4EBB07F29743873A87CF62C26D703507DA@NAMAIL4.ad.lsil.com> References: <664A4EBB07F29743873A87CF62C26D703507DA@NAMAIL4.ad.lsil.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Oct 2006 17:21:08 -0600 "Moore, Eric" wrote: > On Monday, October 02, 2006 2:40 PM, Andrew Morton wrote: > > > > > Yeah, Bryce@osdl is hitting this. Apparently it can be worked around > > by compiling the driver as a module. > > > > What I saw in Bryces trace was the driver was not receiving interrupts > for > the first command sent after interrutps were enabled. This was a config > page > for spi port pages. Since this command timed out, an internal timeout > handler was called, > and we issued an internal host reset. The host reset called each > driver, > such as mptspi, mptfc, mptsas, callback handers. That ended with > as pacin in mptspi, due to we assume ioc->hd to be a valid pointer. > We don't allocate ioc->hd to well after mpt_attach, which is where the > config > page that timed out. We could prevent the panic in mptspi, but that > doesn't fix the problem why we are not getting interrupts. > > I have a 2.6.18 gold kernel, and that works fine with modules. > There are no changes in mpt stack since 2.6.18 that would effect > interrupts. > Do you know of any changes in kernel effecting interrupts? I suspect > that > modules versus linked drivers into kernel would matter, or would it? There are lots and lots of interrupt changes, some now in mainline, some not. There's a known-problematic PCI resource allocation bug now in mainline too. It appears that this can cause devices to not get assigned an interrupt. So yes, this is probably the trigger. But as a secondary thing, it appears that the driver will crash if something goes wrong with the interrupt setup?