From: Andrew Morton <akpm@osdl.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, s270-linux@mail.0pointer.de
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support
Date: Mon, 2 Oct 2006 18:48:40 -0700 [thread overview]
Message-ID: <20061002184840.e5c090f2.akpm@osdl.org> (raw)
In-Reply-To: <20061003011056.GA28731@ecstasy.ring2.lan>
On Tue, 3 Oct 2006 03:10:56 +0200
Lennart Poettering <mzxreary@0pointer.de> wrote:
> From: Lennart Poettering <mzxreary@0pointer.de>
>
> A driver for the special features of MSI S270 laptops (and maybe other
> MSI laptops). This driver implements a backlight device for
> controlling LCD brightness (/sys/class/backlight/msi-laptop-bl/). In
> addition it allows access to the WLAN and Bluetooth states through a
> platform driver (/sys/devices/platform/msi-laptop-pf/).
>
> ...
>
err, this driver has only about fifteen tab characters in it. The whole
thing is using lean-on-the-spacebar instead of hard tabs.
fix, please??
> +static ssize_t store_lcd_level(
> + struct device *dev, struct device_attribute *attr, const char *buf, size_t count) {
No, kernel-style is
static ssize_t store_lcd_level(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
or thereabouts.
next prev parent reply other threads:[~2006-10-03 1:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 1:10 Lennart Poettering
2006-10-03 1:48 ` Andrew Morton [this message]
2006-10-03 2:27 ` Dmitry Torokhov
2006-10-04 1:28 ` Lennart Poettering
2006-10-04 1:37 ` Dmitry Torokhov
2006-10-04 1:53 ` Lennart Poettering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002184840.e5c090f2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=s270-linux@mail.0pointer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome