From: Karsten Wiese <annabellesgarden@yahoo.de>
To: linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net,
Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
Date: Tue, 3 Oct 2006 14:33:56 +0200 [thread overview]
Message-ID: <200610031433.56957.annabellesgarden@yahoo.de> (raw)
Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
substream can be NULL......
in mainline, bug was introduced by:
2006-06-22 [ALSA] Add O_APPEND flag support to PCM
Signed-off-by: Karsten Wiese <annabellesgarden@yahoo.de>
--- alsa-kernel/usb/usx2y/usx2yhwdeppcm.c~ 2006-06-29 23:25:30.000000000 +0200
+++ alsa-kernel/usb/usx2y/usx2yhwdeppcm.c 2006-10-03 14:05:12.000000000 +0200
@@ -632,7 +632,7 @@ static int usX2Y_pcms_lock_check(struct
for (s = 0; s < 2; ++s) {
struct snd_pcm_substream *substream;
substream = pcm->streams[s].substream;
- if (SUBSTREAM_BUSY(substream))
+ if (substream && SUBSTREAM_BUSY(substream))
err = -EBUSY;
}
}
next reply other threads:[~2006-10-03 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 12:33 Karsten Wiese [this message]
2006-10-04 15:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610031433.56957.annabellesgarden@yahoo.de \
--to=annabellesgarden@yahoo.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®