From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/base: error handling fixes
Date: Wed, 4 Oct 2006 17:24:34 +0200 [thread overview]
Message-ID: <20061004172434.1a2ddb71@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20061004130554.GA25974@havoc.gtf.org>
On Wed, 4 Oct 2006 09:05:54 -0400,
Jeff Garzik <jeff@garzik.org> wrote:
> static int __cpuinit topology_cpu_callback(struct notifier_block *nfb,
> @@ -112,17 +110,18 @@ static int __cpuinit topology_cpu_callba
> {
> unsigned int cpu = (unsigned long)hcpu;
> struct sys_device *sys_dev;
> + int rc = 0;
>
> sys_dev = get_cpu_sysdev(cpu);
> switch (action) {
> case CPU_ONLINE:
> - topology_add_dev(sys_dev);
> + rc = topology_add_dev(sys_dev);
> break;
> case CPU_DEAD:
> topology_remove_dev(sys_dev);
> break;
> }
> - return NOTIFY_OK;
> + return rc ? NOTIFY_BAD : NOTIFY_OK;
> }
Wouldn't that also require that _cpu_up checked the return code when
doing CPU_ONLINE notification (and clean up on error)?
next prev parent reply other threads:[~2006-10-04 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 13:05 Jeff Garzik
2006-10-04 14:44 ` Cornelia Huck
2006-10-04 15:24 ` Cornelia Huck [this message]
2006-10-05 8:17 ` Heiko Carstens
2006-10-05 11:16 ` Jeff Garzik
2006-10-05 12:48 ` Heiko Carstens
2006-10-05 12:58 ` Jeff Garzik
2006-10-05 13:16 ` Heiko Carstens
2006-10-09 7:29 ` [patch 1/2] sysfs: allow removal of nonexistent sysfs groups Heiko Carstens
2006-10-09 7:40 ` Andrew Morton
2006-10-09 7:49 ` Heiko Carstens
2006-10-09 7:30 ` [patch 2/2] cpu topology: various fixes/cleanups Heiko Carstens
2006-10-05 13:15 ` [PATCH] drivers/base: error handling fixes Cornelia Huck
2006-10-05 13:20 ` Heiko Carstens
2006-10-05 13:45 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004172434.1a2ddb71@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®