From: Randy Dunlap <rdunlap@xenotime.net>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, netwiz@crc.id.au
Subject: Re: [Patch] Dereference in drivers/usb/misc/adutux.c
Date: Thu, 5 Oct 2006 08:21:31 -0700 [thread overview]
Message-ID: <20061005082131.c9a0ecd0.rdunlap@xenotime.net> (raw)
In-Reply-To: <1160042489.3101.2.camel@alice>
On Thu, 05 Oct 2006 12:01:29 +0200 Eric Sesterhenn wrote:
> hi,
>
> in two of the error cases, dev is still NULL,
> and we dereference it. Spotted by coverity (cid#1428, 1429)
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.19-rc1/drivers/usb/misc/adutux.c.orig 2006-10-05 11:57:52.000000000 +0200
> +++ linux-2.6.19-rc1/drivers/usb/misc/adutux.c 2006-10-05 11:58:19.000000000 +0200
> @@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
> retval = adu_release_internal(dev);
>
> exit:
> - up(&dev->sem);
> + if(dev)
> + up(&dev->sem);
> dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
> return retval;
> }
if (dev)
space after if, for, while, etc. No space after function names.
---
~Randy
next prev parent reply other threads:[~2006-10-05 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 10:01 Eric Sesterhenn
2006-10-05 15:21 ` Randy Dunlap [this message]
2006-10-05 22:09 ` Eric Sesterhenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005082131.c9a0ecd0.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netwiz@crc.id.au \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®