From: Andrew Morton <akpm@osdl.org>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] sound/oss/btaudio.c: ioremap balanced with iounmap
Date: Fri, 6 Oct 2006 13:50:18 -0700 [thread overview]
Message-ID: <20061006135018.ec3c55de.akpm@osdl.org> (raw)
In-Reply-To: <1160113132.19143.128.camel@amol.verismonetworks.com>
On Fri, 06 Oct 2006 11:08:52 +0530
Amol Lad <amol@verismonetworks.com> wrote:
> ioremap must be balanced by an iounmap and failing to do so can result
> in a memory leak.
>
> Tested (compilation only):
> - using allmodconfig
> - making sure the files are compiling without any warning/error due to
> new changes
>
> Signed-off-by: Amol Lad <amol@verismonetworks.com>
> ---
> Forwarding to lkml as got no response from linux-sound
> ---
> btaudio.c | 2 ++
> 1 files changed, 2 insertions(+)
> ---
> diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/sound/oss/btaudio.c linux-2.6.19-rc1/sound/oss/btaudio.c
> --- linux-2.6.19-rc1-orig/sound/oss/btaudio.c 2006-09-21 10:15:52.000000000 +0530
> +++ linux-2.6.19-rc1/sound/oss/btaudio.c 2006-10-05 15:21:32.000000000 +0530
> @@ -1013,6 +1013,7 @@ static int __devinit btaudio_probe(struc
> return 0;
>
> fail4:
> + iounmap(bta->mmio);
> unregister_sound_dsp(bta->dsp_analog);
> fail3:
> if (digital)
> @@ -1051,6 +1052,7 @@ static void __devexit btaudio_remove(str
> free_irq(bta->irq,bta);
> release_mem_region(pci_resource_start(pci_dev,0),
> pci_resource_len(pci_dev,0));
> + iounmap(bta->mmio);
>
> /* remove from linked list */
> if (bta == btaudios) {
No, that misses several cases. Please review this version:
--- a/sound/oss/btaudio.c~sound-oss-btaudioc-ioremap-balanced-with-iounmap
+++ a/sound/oss/btaudio.c
@@ -1020,6 +1020,7 @@ static int __devinit btaudio_probe(struc
fail2:
free_irq(bta->irq,bta);
fail1:
+ iounmap(bta->mmio);
kfree(bta);
fail0:
release_mem_region(pci_resource_start(pci_dev,0),
@@ -1051,6 +1052,7 @@ static void __devexit btaudio_remove(str
free_irq(bta->irq,bta);
release_mem_region(pci_resource_start(pci_dev,0),
pci_resource_len(pci_dev,0));
+ iounmap(bta->mmio);
/* remove from linked list */
if (bta == btaudios) {
_
prev parent reply other threads:[~2006-10-06 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 5:38 Amol Lad
2006-10-06 20:50 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006135018.ec3c55de.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=amol@verismonetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®