From: Andrew Morton <akpm@osdl.org>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/9] sound/oss/msnd_pinnacle.c: ioremap balanced with iounmap
Date: Fri, 6 Oct 2006 16:03:24 -0700 [thread overview]
Message-ID: <20061006160324.142ccebf.akpm@osdl.org> (raw)
In-Reply-To: <1160113137.19143.140.camel@amol.verismonetworks.com>
On Fri, 06 Oct 2006 11:08:57 +0530
Amol Lad <amol@verismonetworks.com> wrote:
> msnd_pinnacle.c | 10 ++++++++++
This driver fails to check that ioremap() actually succeeded. Hence with
this patch we can end up doing iounmap(NULL).
Now it _could_ be that the kernel permits iounmap(NULL). But I don't
recall that being the rule, and from my reading the powerpc 64-bit iounmap
(at least) will go splat if we do this to it. Most other implementations
will permit iounmap(NULL) by accident.
next prev parent reply other threads:[~2006-10-06 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 5:38 Amol Lad
2006-10-06 23:03 ` Andrew Morton [this message]
2006-10-07 5:09 ` Amol Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006160324.142ccebf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=amol@verismonetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome