From: Andrew Morton <akpm@osdl.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VM: Fix the gfp_mask in invalidate_complete_page2
Date: Fri, 6 Oct 2006 16:20:32 -0700 [thread overview]
Message-ID: <20061006162032.9192ae1b.akpm@osdl.org> (raw)
In-Reply-To: <4526E229.2020707@RedHat.com>
On Fri, 06 Oct 2006 19:09:29 -0400
Steve Dickson <SteveD@redhat.com> wrote:
> > Well, it wasn't attached, but I can simulate it.
> >
> > invalidate_complete_page() wants to be called from inside spinlocks by
> > drop_pagecache(), so if we wanted to pull the same trick there we'd need to
> > pass a new flag into invalidate_inode_pages().
> That seems abit broken (wrt performance) that drop_pagecache_sb() holds
> the fairly popular inode_lock while it invalidate pages...
> Nobody else seem to...
Yes, it was very rude of me. But it's just a debugging thing, and is
privileged.
I removed a cond_resched() from in there in the process. If we make the
invalidate_inode_pages() caller pass in a must_be_atomic flag then the
cond_resched() can be resuscitated.
next prev parent reply other threads:[~2006-10-06 23:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 21:37 Trond Myklebust
2006-10-06 21:49 ` Steve Dickson
2006-10-06 22:16 ` Trond Myklebust
2006-10-06 22:19 ` Trond Myklebust
2006-10-06 22:40 ` Andrew Morton
2006-10-06 23:09 ` Steve Dickson
2006-10-06 23:20 ` Andrew Morton [this message]
2006-10-07 2:33 ` Andrew Morton
2006-10-10 9:43 ` David Howells
2006-10-10 11:42 ` Trond Myklebust
2006-10-10 12:18 ` Steve Dickson
2006-10-10 12:27 ` Trond Myklebust
2006-10-10 13:22 ` Steve Dickson
2006-10-10 13:32 ` Trond Myklebust
2006-10-10 12:49 ` David Howells
2006-10-10 13:15 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006162032.9192ae1b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome