From: Andrew Morton <akpm@osdl.org>
To: Suzuki K P <suzuki@in.ibm.com>
Cc: Erik Mouw <erik@harddisk-recovery.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, andmike@us.ibm.com
Subject: Re: [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix rescan_partitions to return errors properly - take 2)
Date: Fri, 6 Oct 2006 19:45:50 -0700 [thread overview]
Message-ID: <20061006194550.8351ed5e.akpm@osdl.org> (raw)
In-Reply-To: <452706EA.3040702@in.ibm.com>
On Fri, 06 Oct 2006 18:46:18 -0700
Suzuki K P <suzuki@in.ibm.com> wrote:
> * The check_partition() stops its probe once it hits an I/O error from the partition checkers. This would prevent the actual partition checker getting a chance to verify the partition. So, this patch lets the check_partition continue probing untill it hits a success while recording the I/O error which might have been reported by the checking routines.
>
> Also, it does some cleanup of the partition methods for ibm, atari and amiga to return -1 upon hitting an I/O error.
What is the significance of a `return 1', a `return 0' and a `return -EFOO' in these
functions? It all looks rather odd.
prev parent reply other threads:[~2006-10-07 2:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 1:00 [RFC] PATCH to fix rescan_partitions to return errors properly Suzuki Kp
2006-10-04 13:09 ` Erik Mouw
2006-10-04 16:50 ` Suzuki Kp
2006-10-04 17:08 ` Erik Mouw
2006-10-04 17:37 ` Suzuki Kp
2006-10-05 10:40 ` Erik Mouw
2006-10-05 20:32 ` [RFC] PATCH to fix rescan_partitions to return errors properly - take 2 Suzuki Kp
2006-10-05 22:07 ` Andrew Morton
2006-10-06 12:53 ` Erik Mouw
2006-10-06 17:43 ` Suzuki K P
2006-10-06 21:07 ` Erik Mouw
2006-10-07 1:46 ` [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix rescan_partitions to return errors properly - take 2) Suzuki K P
2006-10-07 2:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006194550.8351ed5e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=andmike@us.ibm.com \
--cc=erik@harddisk-recovery.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®