From: Matthew Wilcox <matthew@wil.cx>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, akpm@osdl.org, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4]
Date: Fri, 6 Oct 2006 14:39:19 -0600 [thread overview]
Message-ID: <20061006203919.GS2563@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0610062232210.30417@yvahk01.tjqt.qr>
On Fri, Oct 06, 2006 at 10:33:19PM +0200, Jan Engelhardt wrote:
>
> >+ * the massive ternary operator construction
> >+ (sizeof(n) <= 4) ? \
> >+ __ilog2_u32(n) : \
> >+ __ilog2_u64(n) \
>
> Should not this be: sizeof(n) <= sizeof(u32)
Were you planning on porting Linux to a machine with non-8-bit-bytes any
time soon? Because there's a lot more to fix than this.
next prev parent reply other threads:[~2006-10-06 20:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 13:34 David Howells
2006-10-06 13:34 ` [PATCH 2/4] LOG2: Alter roundup_pow_of_two() so that it can use a ilog2() on a constant " David Howells
2006-10-06 13:34 ` [PATCH 3/4] LOG2: Alter get_order() so that it can make use of " David Howells
2006-10-06 13:34 ` [PATCH 4/4] LOG2: Provide ilog2() fallbacks for powerpc " David Howells
2006-10-06 14:17 ` [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel " Matthew Wilcox
2006-10-06 17:17 ` Christoph Lameter
2006-10-09 10:11 ` David Howells
2006-10-09 11:06 ` Christoph Lameter
2006-10-09 12:09 ` David Howells
2006-10-09 17:17 ` Christoph Lameter
2006-10-10 9:58 ` David Howells
2006-10-06 14:33 ` David Howells
2006-10-06 20:33 ` Jan Engelhardt
2006-10-06 20:39 ` Matthew Wilcox [this message]
2006-10-06 20:52 ` Jan Engelhardt
2006-10-09 8:06 ` David Howells
2006-10-09 8:36 ` Jan Engelhardt
2006-10-09 9:51 ` Kyle Moffett
2006-10-09 10:26 ` Arnd Bergmann
2006-10-09 10:32 ` Stephen Rothwell
2006-10-09 12:20 ` Jan Engelhardt
2006-10-09 13:09 ` Geert Uytterhoeven
2006-10-09 14:52 ` Arnd Bergmann
2006-10-09 15:05 ` Geert Uytterhoeven
2006-10-09 15:27 ` Arnd Bergmann
2006-10-09 15:31 ` Geert Uytterhoeven
2006-10-09 16:47 ` Arnd Bergmann
2006-10-10 7:55 ` David Woodhouse
2006-10-10 12:12 ` Arnd Bergmann
2006-10-09 12:54 ` David Howells
2006-10-09 20:00 ` Jan Engelhardt
2006-10-09 20:36 ` Andreas Schwab
2006-10-10 9:41 ` Jan Engelhardt
2006-10-10 11:42 ` Arnd Bergmann
2006-10-09 20:55 ` Samuel Tardieu
2006-10-10 12:23 ` David Howells
2006-10-07 23:50 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006203919.GS2563@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome