From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932925AbWJIPJN (ORCPT ); Mon, 9 Oct 2006 11:09:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932929AbWJIPJN (ORCPT ); Mon, 9 Oct 2006 11:09:13 -0400 Received: from xenotime.net ([66.160.160.81]:49619 "HELO xenotime.net") by vger.kernel.org with SMTP id S932922AbWJIPJM (ORCPT ); Mon, 9 Oct 2006 11:09:12 -0400 Date: Mon, 9 Oct 2006 08:10:37 -0700 From: Randy Dunlap To: Stefan Seyfried Cc: Kristen Carlson Accardi , linux-kernel@vger.kernel.org, jgarzik@pobox.com, linux-ide@vger.kernel.org Subject: Re: [patch 1/2] libata: _GTF support Message-Id: <20061009081037.620bb5e3.rdunlap@xenotime.net> In-Reply-To: <20061009114150.GA32716@suse.de> References: <20060927223441.205181000@localhost.localdomain> <20060927153627.c931de2d.kristen.c.accardi@intel.com> <20061009114150.GA32716@suse.de> Organization: YPO4 X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Oct 2006 13:41:50 +0200 Stefan Seyfried wrote: > On Wed, Sep 27, 2006 at 03:36:27PM -0700, Kristen Carlson Accardi wrote: > > _GTF is an acpi method that is used to reinitialize the drive. It returns > > a task file containing ata commands that are sent back to the drive to restore > > it to boot up defaults. > > > > Signed-off-by: Kristen Carlson Accardi > > > > --- > > Documentation/kernel-parameters.txt | 5 > > > --- 2.6-mm.orig/Documentation/kernel-parameters.txt > > +++ 2.6-mm/Documentation/kernel-parameters.txt > > @@ -48,6 +48,7 @@ parameter is applicable: > > ISAPNP ISA PnP code is enabled. > > ISDN Appropriate ISDN support is enabled. > > JOY Appropriate joystick support is enabled. > > + LIBATA Libata driver is enabled > > LP Printer support is enabled. > > LOOP Loopback device support is enabled. > > M68k M68k architecture is enabled. > > @@ -1013,6 +1014,10 @@ and is between 256 and 4096 characters. > > emulation library even if a 387 maths coprocessor > > is present. > > > > + noacpi [LIBATA] Disables use of ACPI in libata suspend/resume > > + when set. > > + Format: > > this will confuse users that already think they can disable ACPI with "noacpi" > (instead of "acpi=off") and that already fight with "noapic". I have seen too > many confusions of this kind in bugreports. > > Couldn't it be made "libata=noacpi" like we have "pci=noacpi" already? It only applies to the libata module, so it could be more fully documented as "libata.noacpi=1" to disable ACPI for libata. We don't usually do that in Documentation/kernel-parameters.txt, but there are a few cases/examples of doing so. Of course, that's for libata built-in the kernel image. If libata is a loadable module, it's just modprobe libata noacpi=1 or set it in /etc/modprobe.conf. --- ~Randy