From: Andrew Morton <akpm@osdl.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix IO error reporting on fsync()
Date: Mon, 9 Oct 2006 11:20:11 -0700 [thread overview]
Message-ID: <20061009112011.b8c84e54.akpm@osdl.org> (raw)
In-Reply-To: <20061009114040.GI17620@atrey.karlin.mff.cuni.cz>
On Mon, 9 Oct 2006 13:40:41 +0200
Jan Kara <jack@suse.cz> wrote:
> > What about putting an address_space* into the buffer_head? Transfer the
> > EIO state into the address_space within, say, __remove_assoc_queue()?
> Yes, that's of course possible. But it enlarges each buffer head by 4
> bytes (or 8 on 64-bit arch).
I suspect we could get that back by removing buffer_head.b_bdev. That's
not a trivial thing to do, but should be feasible.
We can't just do bh->b_page->mapping->host->i_sb->s_bdev because of races
with trunate, plus the general horror of it all. But I expect that all
callers of submit_bh() have the blockdev* easily available by other means,
so adding a `struct block_device*' argument to submit_bh() would get us
there.
next prev parent reply other threads:[~2006-10-09 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 11:49 Jan Kara
2006-10-06 11:55 ` [PATCH 1/3] " Jan Kara
2006-10-06 11:56 ` [PATCH 2/3] " Jan Kara
2006-10-06 11:57 ` [PATCH 3/3] " Jan Kara
2006-10-07 6:06 ` [PATCH 0/3] " Andrew Morton
2006-10-09 11:40 ` Jan Kara
2006-10-09 18:20 ` Andrew Morton [this message]
2006-10-10 11:56 ` Jan Kara
2006-10-09 14:47 ` [PATCH] Try to avoid a pessimistic vmalloc() recursion Eric Dumazet
2006-10-09 16:25 ` Nick Piggin
2006-10-09 19:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009112011.b8c84e54.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®