From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-git] Fix error handling in create_files()
Date: Mon, 9 Oct 2006 19:22:01 +0200 [thread overview]
Message-ID: <20061009192201.140eae35@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20061009170357.GA16816@dreamland.darkstar.lan>
On Mon, 9 Oct 2006 19:03:57 +0200,
Luca Tettamanti <kronos.it@gmail.com> wrote:
> While we are at it: is it safe to always call sysfs_remove_group even if
> the preceding sysfs_create_group failed?
No, it will oops in remove_dir(). (See also the recent discussion in
"drivers/base: error handling fixes" - drivers/base/topology.c has
problems in that area as well...)
--
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
prev parent reply other threads:[~2006-10-09 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 16:40 Luca Tettamanti
2006-10-09 16:48 ` Greg KH
2006-10-09 17:03 ` Luca Tettamanti
2006-10-09 17:22 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009192201.140eae35@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=gregkh@suse.de \
--cc=kronos.it@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®