From: Herbert Xu <herbert@gondor.apana.org.au>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
Date: Tue, 10 Oct 2006 13:53:39 +1000 [thread overview]
Message-ID: <20061010035339.GA29279@gondor.apana.org.au> (raw)
In-Reply-To: <20061009115526.GA10857@localhost>
On Mon, Oct 09, 2006 at 08:55:26PM +0900, Akinobu Mita wrote:
>
> I misunderstood about crypto_alloc_tfm().
>
> BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm().
> Should we mark it as __deprecated?
Probably. Although anybody using crypto_alloc_tfm will probably
also use the old crypto interface which gives plenty of warnings
already.
> - __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure.
> But it returns NULL.
>
> - crypto_alloc_base() may not return -EINTR on signal_pending()
>
> I'll fix the patch and resend with more clear description later.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2006-10-10 3:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 8:58 Akinobu Mita
2006-10-09 9:01 ` [PATCH 2/2] crypto: delete duplicated code Akinobu Mita
2006-10-09 11:14 ` [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value Herbert Xu
2006-10-09 11:55 ` Akinobu Mita
2006-10-10 3:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010035339.GA29279@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akinobu.mita@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®