From: Vadim Lobanov <vlobanov@speakeasy.net>
To: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@osdl.org>
Subject: Re: BUG in filp_close() (was: Re: 2.6.19-rc1-mm1)
Date: Tue, 10 Oct 2006 15:38:36 -0700 [thread overview]
Message-ID: <200610101538.36358.vlobanov@speakeasy.net> (raw)
In-Reply-To: <1160518024.28923.33.camel@kleikamp.austin.ibm.com>
On Tuesday 10 October 2006 15:07, Dave Kleikamp wrote:
> On Tue, 2006-10-10 at 10:47 -0500, Dave Kleikamp wrote:
> > On Tue, 2006-10-10 at 00:09 -0700, Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc
> > >1/2.6.19-rc1-mm1/
> >
> > I'm seeing an exception in filp_close(), called from sys_dup2(). I have
> > only seen it when I try to start up a java application (Lotus
> > Workplace).
> >
> > I suspect that it may be related to the fdtable work, but I haven't
> > investigated it too closely.
>
> Still don't know exactly what's going on here. In case it helps, this
> is the call to dup2() from strace output:
>
> 1419 open("/dev/null", O_RDWR) = 7
> 1419 getrlimit(RLIMIT_NOFILE, {rlim_cur=1024, rlim_max=1024}) = 0
> 1419 dup2(7, 524) = 524
> 1419 dup2(7, 525 <unfinished ...>
>
> > > +fdtable-delete-pointless-code-in-dup_fd.patch
> > > +fdtable-make-fdarray-and-fdsets-equal-in-size.patch
> > > +fdtable-remove-the-free_files-field.patch
> > > +fdtable-implement-new-pagesize-based-fdtable-allocator.patch
> > >
> > > Redo the fdtable code.
D'oh!!! Everybody who hit this bug can feel free to call me a moron now! (And
Andrew will probably take me up on that offer, for all the residual flak he
caught. :)) The problem is in the following logic:
+ nr++;
+ nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
+ nr = roundup_pow_of_two(nr);
+ nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
+ if (nr > NR_OPEN)
+ nr = NR_OPEN;
The problem is that roundup_pow_of_two() will not necessarily bring the array
up to the necessary size, and we get an array overflow. This is clearly
visible in the example above: dup2(..., 524) with a PAGE_SIZE of 4K. (Thanks
for sending that in, Dave.) Let me think about the best way to fix this
computation, and I'll send out a patch for you folks to test to see if it
fixes your problem, if you'll oblige.
-- Vadim Lobanov, idiot of the day
next prev parent reply other threads:[~2006-10-10 22:38 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 7:09 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 7:20 ` 2.6.19-rc1-mm1 Arjan van de Ven
2006-10-10 7:45 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 8:03 ` 2.6.19-rc1-mm1 Arjan van de Ven
2006-10-10 13:14 ` RSS accounting (was: Re: 2.6.19-rc1-mm1) Peter Zijlstra
2006-10-10 16:13 ` Arjan van de Ven
2006-10-10 23:54 ` Eric W. Biederman
2006-10-11 8:47 ` Arjan van de Ven
2006-10-11 12:07 ` Eric W. Biederman
2006-10-11 13:55 ` Arjan van de Ven
2006-10-11 17:15 ` Chen, Kenneth W
2006-10-11 22:36 ` Benjamin LaHaise
2006-10-10 7:31 ` 2.6.19-rc1-mm1 Miguel Ojeda
2006-10-10 8:10 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 9:57 ` 2.6.19-rc1-mm1 Miguel Ojeda
2006-10-10 18:25 ` 2.6.19-rc1-mm1 Jeremy Fitzhardinge
2006-10-10 12:19 ` 2.6.19-rc1-mm1 Theodore Tso
2006-10-10 12:26 ` 2.6.19-rc1-mm1 Arjan van de Ven
2006-10-10 16:21 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 13:10 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-10 14:04 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-11 5:35 ` 2.6.19-rc1-mm1 Neil Brown
2006-10-11 10:48 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-11 11:23 ` 2.6.19-rc1-mm1 Arjan van de Ven
2006-10-11 13:08 ` _cpu_down deadlock [was Re: 2.6.19-rc1-mm1] Neil Brown
2006-10-11 13:32 ` Rusty Russell
2006-10-11 16:39 ` Andrew Morton
2006-10-11 23:46 ` Neil Brown
2006-10-12 6:51 ` Arjan van de Ven
2006-10-12 7:53 ` SPAM: " Neil Brown
2006-10-12 8:04 ` Andrew Morton
2006-10-13 4:49 ` Neil Brown
2006-10-10 15:47 ` BUG in filp_close() (was: Re: 2.6.19-rc1-mm1) Dave Kleikamp
2006-10-10 22:07 ` Dave Kleikamp
2006-10-10 22:14 ` Vadim Lobanov
2006-10-10 22:38 ` Vadim Lobanov [this message]
2006-10-10 16:09 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-10 19:04 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 21:44 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-10 21:52 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-20 20:44 ` 2.6.19-rc1-mm1 Thomas Gleixner
2006-10-10 17:15 ` BUG() in copy_fdtable() with 64K pages (2.6.19-rc1-mm1) Olof Johansson
2006-10-10 19:34 ` Andrew Morton
2006-10-10 20:20 ` Linas Vepstas
2006-10-10 20:31 ` Vadim Lobanov
2006-10-10 23:05 ` Linas Vepstas
2006-10-10 18:09 ` 2.6.19-rc1-mm1 Jeremy Fitzhardinge
2006-10-10 19:25 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 19:41 ` 2.6.19-rc1-mm1 Jeremy Fitzhardinge
2006-10-10 23:10 ` 2.6.19-rc1-mm1 Paul Mackerras
2006-10-10 23:16 ` 2.6.19-rc1-mm1 Jeremy Fitzhardinge
2006-10-10 23:37 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-10 22:17 ` 2.6.19-rc1-mm1 Badari Pulavarty
2006-10-11 6:56 ` 2.6.19-rc1-mm1 Arjan van de Ven
2006-10-11 3:13 ` 2.6.19-rc1-mm1 Badari Pulavarty
2006-10-11 4:01 ` 2.6.19-rc1-mm1 Andrew Morton
[not found] ` <1160578934.1447.1.camel@dyn9047017100.beaverton.ibm.com>
2006-10-11 16:56 ` 2.6.19-rc1-mm1 (ext4 problem ?) Andrew Morton
2006-10-11 17:08 ` Badari Pulavarty
2006-10-11 12:51 ` 2.6.19-rc1-mm1 Theodore Tso
2006-10-11 19:54 ` 2.6.19-rc1-mm1 Martin J. Bligh
2006-10-11 21:58 ` 2.6.19-rc1-mm1 Badari Pulavarty
2006-10-16 15:56 ` 2.6.19-rc1-mm1 Andy Whitcroft
2006-10-11 19:59 ` 2.6.19-rc1-mm1 Martin J. Bligh
2006-10-11 20:10 ` 2.6.19-rc1-mm1 Michal Piotrowski
2006-10-11 21:47 ` 2.6.19-rc1-mm1 Andrew Morton
2006-10-12 10:22 ` 2.6.19-rc1-mm1 Andy Whitcroft
2006-10-12 18:09 ` 2.6.19-rc1-mm1 Badari Pulavarty
2006-10-12 18:52 ` 2.6.19-rc1-mm1 Vadim Lobanov
2006-10-12 19:01 ` 2.6.19-rc1-mm1 Badari Pulavarty
2006-10-11 21:19 ` 2.6.19-rc1-mm1 Michael Lothian
2006-10-12 12:18 ` 2.6.19-rc1-mm1 - locks when using "dd bs=1M" from card reader Helge Hafting
2006-10-12 18:29 ` Andrew Morton
2006-10-13 13:11 ` Helge Hafting
2006-10-13 16:29 ` Andrew Morton
2006-10-13 18:10 ` [linux-usb-devel] " Alan Stern
2006-10-18 9:31 ` Helge Hafting
2006-10-18 16:26 ` Alan Stern
2006-10-19 12:25 ` Helge Hafting
2006-10-19 18:40 ` Alan Stern
2006-10-19 18:57 ` Christopher "Monty" Montgomery
2006-10-20 11:44 ` Helge Hafting
2006-10-20 15:55 ` Alan Stern
2006-10-23 9:12 ` Helge Hafting
2006-10-23 14:13 ` Alan Stern
2006-10-23 20:36 ` Christopher "Monty" Montgomery
2006-10-24 10:16 ` Helge Hafting
2006-10-24 14:09 ` Alan Stern
2006-10-12 18:37 ` 2.6.19-rc1-mm1 Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610101538.36358.vlobanov@speakeasy.net \
--to=vlobanov@speakeasy.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®