From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030291AbWJKGAu (ORCPT ); Wed, 11 Oct 2006 02:00:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030616AbWJKGAu (ORCPT ); Wed, 11 Oct 2006 02:00:50 -0400 Received: from smtp.osdl.org ([65.172.181.4]:37570 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1030291AbWJKGAt (ORCPT ); Wed, 11 Oct 2006 02:00:49 -0400 Date: Tue, 10 Oct 2006 23:00:42 -0700 From: Andrew Morton To: Nick Piggin Cc: Nick Piggin , Linux Memory Management , Linux Kernel , Linus Torvalds Subject: Re: [patch 2/5] mm: fault vs invalidate/truncate race fix Message-Id: <20061010230042.3d4e4df1.akpm@osdl.org> In-Reply-To: <452C838A.70806@yahoo.com.au> References: <20061010121314.19693.75503.sendpatchset@linux.site> <20061010121332.19693.37204.sendpatchset@linux.site> <20061010213843.4478ddfc.akpm@osdl.org> <452C838A.70806@yahoo.com.au> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2006 15:39:22 +1000 Nick Piggin wrote: > But I see that it does read twice. Do you want that behaviour retained? It > seems like at this level it would be logical to read it once and let lower > layers take care of any retries? argh. Linus has good-sounding reasons for retrying the pagefault-path's read a single time, but I forget what they are. Something to do with networked filesystems? (adds cc)