From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH 2.6.19-rc1-mm1] Export jiffies_to_timespec()
Date: Wed, 11 Oct 2006 11:17:39 -0700 [thread overview]
Message-ID: <20061011111739.09c25a8e.akpm@osdl.org> (raw)
In-Reply-To: <20061011161628.GA1873@infradead.org>
On Wed, 11 Oct 2006 17:16:28 +0100
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Oct 10, 2006 at 05:36:54PM -0700, Jeremy Fitzhardinge wrote:
> > Export jiffies_to_timespec; previously modules used the inlined header
> > version.
>
> NACK, drivers shouldn know about these timekeeping details and no
> in-tree driver uses it (fortunately)
Disagree.
a) `jiffies' and `timepsec' are hardly "details". They are basic
kernel-wide concepts. timespecs are even known to userspace. Exporting
a helper function which converts from one to the other is perfectly
reasonable.
b) jiffies_to_timespec() was previously available to modules. We
changed that without notice and we changed it *by accident*. There was
no intention to withdraw jiffies_to_timespec() from the
available-to-modules API.
If we really wanted to withdraw jiffies_to_timespec() then we'd mark it
__deprecated_for_modules for a while, then withdraw it. But there's no
earthly reason why we'd want to withdraw it: the export makes sense.
next prev parent reply other threads:[~2006-10-11 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 0:36 Jeremy Fitzhardinge
2006-10-11 7:02 ` Arjan van de Ven
2006-10-11 7:07 ` Jeremy Fitzhardinge
2006-10-11 16:16 ` Christoph Hellwig
2006-10-11 18:17 ` Andrew Morton [this message]
2006-10-28 16:50 ` Christoph Hellwig
2006-10-11 19:48 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061011111739.09c25a8e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jeremy@goop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®