From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161246AbWJKUcM (ORCPT ); Wed, 11 Oct 2006 16:32:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161248AbWJKUcM (ORCPT ); Wed, 11 Oct 2006 16:32:12 -0400 Received: from xenotime.net ([66.160.160.81]:15039 "HELO xenotime.net") by vger.kernel.org with SMTP id S1161246AbWJKUcK (ORCPT ); Wed, 11 Oct 2006 16:32:10 -0400 Date: Wed, 11 Oct 2006 13:33:37 -0700 From: Randy Dunlap To: "Dmitry Torokhov" Cc: "Alexey Dobriyan" , linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: misused local_irq_disable() in analog.c? Message-Id: <20061011133337.5d78ace5.rdunlap@xenotime.net> In-Reply-To: References: Organization: YPO4 X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2006 16:17:33 -0400 Dmitry Torokhov wrote: > On 10/11/06, Alexey Dobriyan wrote: > > Dmitry, take a look at analog_cooked_read(): > > > > do-while loop there contains local_irq_disable()/local_irq_restore(flags); > > which aren't complement. > > > > Should it be > > > > local_irq_save(flags); > > this = gameport_read(gameport) & port->mask; > > GET_TIME(now); > > local_irq_restore(flags); > > > > ? > > Yep, I think so. Patch? Alexey replied on another thread (Re: [PATCH] misuse of strstr): "sorry for absence of patch, I'm on wonders of BY dial-up _and_ Gmail web interface right now." --- ~Randy