Re: patch : hdaps on Thinkpad R52

[Frank Gevaerts <frank@gevaerts.be>]

On Wed, Oct 11, 2006 at 04:07:45PM +0200, Jean Delvare wrote:
> Hi Franck,
> 
> Quoting myself back in April:
> > > I just had a mail from another R52 user, reporting that his system
> > > (also 1846AQG) also reports ThinkPad H.
> > 
> > I gathered data on my side too, the three R52 I had reports for used
> > "ThinkPad R52" but these had different machine type/model. I guess that
> > the 1846AQG is somehow different, but probably you don't know why?
> > 
> > So I suppose we could add that "ThinkPad H" identifier string to the
> > hdaps driver after all, as you proposed in the first place. I'm only
> > worried that the "H" suffix is really short, and I hope that no other
> > model not supported by the driver (or needing the invert option) will
> > ever have the same identifier. Time will tell.
> 
> I am told that a newer BIOS of the Thinkpad R52 fixes the machine name
> in the DMI table.
> http://www.thinkwiki.org/wiki/List_of_DMI_IDs#R_series
> Can you please confirm this by upgrading the BIOS of your machine and
> removing the "ThinkPad H" entry from the hdaps driver?

BIOS 1.25 does indeed report "ThinkPad R52" instead of "ThinkPad H", and
hdaps without "ThinkPad H" works as expected.

Frank

> 
> Thanks,
> -- 
> Jean Delvare

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan