From: Andrew Morton <akpm@osdl.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de,
Don Mullis <dwm@meer.net>, Jens Axboe <axboe@suse.de>
Subject: Re: [patch 5/7] fault-injection capability for disk IO
Date: Thu, 12 Oct 2006 14:08:30 -0700 [thread overview]
Message-ID: <20061012140830.49ff6135.akpm@osdl.org> (raw)
In-Reply-To: <452df232.7451e919.6dde.ffff9127@mx.google.com>
On Thu, 12 Oct 2006 16:43:10 +0900
Akinobu Mita <akinobu.mita@gmail.com> wrote:
> @@ -3134,6 +3174,9 @@ end_io:
> if (unlikely(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)))
> goto end_io;
>
> + if (should_fail_request(bio))
> + goto end_io;
> +
hm, so we simulate IO errors by failing at make_request() time rather than
at end_that_request_last()-time, which is where IO errors would usually be
reported.
If we're testing the filesystem/VFS/etc layers then that's pretty much
equivalent. But perhaps there's an argument for doing both.
Jens, could you have a think about it please?
next prev parent reply other threads:[~2006-10-12 21:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061012074305.047696736@gmail.com>
2006-10-12 7:43 ` [patch 1/7] documentation and scripts Akinobu Mita
2006-10-12 21:37 ` Andrew Morton
2006-10-13 17:47 ` Akinobu Mita
2006-10-13 19:01 ` Andrew Morton
2006-10-12 7:43 ` [patch 2/7] fault-injection capabilities infrastructure Akinobu Mita
2006-10-12 21:03 ` Andrew Morton
2006-10-12 7:43 ` [patch 3/7] fault-injection capability for kmalloc Akinobu Mita
2006-10-12 8:08 ` Pekka Enberg
2006-10-12 7:43 ` [patch 4/7] fault-injection capability for alloc_pages() Akinobu Mita
2006-10-12 21:40 ` Andrew Morton
2006-10-13 17:51 ` Akinobu Mita
2006-10-12 7:43 ` [patch 5/7] fault-injection capability for disk IO Akinobu Mita
2006-10-12 21:08 ` Andrew Morton [this message]
2006-10-13 7:03 ` Jens Axboe
2006-10-12 7:43 ` [patch 6/7] process filtering for fault-injection capabilities Akinobu Mita
2006-10-13 17:28 ` Don Mullis
2006-10-13 18:52 ` Andrew Morton
2006-10-12 7:43 ` [patch 7/7] stacktrace " Akinobu Mita
2006-10-12 21:20 ` Andrew Morton
2006-10-13 18:00 ` Akinobu Mita
2006-10-13 18:12 ` Akinobu Mita
2006-10-13 19:06 ` Andrew Morton
2006-10-13 19:03 ` Andrew Morton
[not found] <20061108174540.976625689@gmail.com>
2006-11-08 17:45 ` [patch 5/7] fault-injection capability for disk IO Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012140830.49ff6135.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=akinobu.mita@gmail.com \
--cc=axboe@suse.de \
--cc=dwm@meer.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®