From: Christoph Hellwig <hch@infradead.org>
To: Casey Dahlin <cjdahlin@ncsu.edu>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Readability improvement of open_exec()
Date: Fri, 13 Oct 2006 08:30:10 +0100 [thread overview]
Message-ID: <20061013073010.GB13531@infradead.org> (raw)
In-Reply-To: <1160707333.3230.14.camel@localhost.localdomain>
> + if (err)
> + goto out;
> +
> + inode = nd.dentry->d_inode;
> + file = ERR_PTR(-EACCES);
> + if ((nd.mnt->mnt_flags & MNT_NOEXEC) ||
> + !S_ISREG(inode->i_mode))
While you're cleaning up things you can put the whole if statement on
one line, it's less than 80 characters long.
next prev parent reply other threads:[~2006-10-13 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 2:42 Casey Dahlin
2006-10-13 7:30 ` Christoph Hellwig [this message]
2006-10-13 19:41 ` Casey Dahlin
2006-10-15 18:10 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013073010.GB13531@infradead.org \
--to=hch@infradead.org \
--cc=cjdahlin@ncsu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®