Re: + convert-cpu-hotplug-notifiers-to-use-raw_notifier-instead-of-blocking_notifier.patch added to -mm tree

[Andrew Morton <akpm@osdl.org>]

On Fri, 13 Oct 2006 22:13:43 +0200
"Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:

> On 13/10/06, Andrew Morton <akpm@osdl.org> wrote:
> > On Fri, 13 Oct 2006 17:19:16 +0200
> > Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
> >
> > > There is something really wrong with this patch (or my hardware).
> > >
> > > echo shutdown > /sys/power/disk; echo disk > /sys/power/state
> > > works fine for me on 2.6.19-rc1-g8770c018.
> > >
> > > On 2.6.19-rc1-mm1 +
> > > convert-cpu-hotplug-notifiers-to-use-raw_notifier-instead-of-blocking_notifier.patch
> > > + Neil's avoid_lockdep_warning_in_md.patch
> > > (http://www.ussg.iu.edu/hypermail/linux/kernel/0610.1/0642.html)
> > > I get a lot of "end_request: I/O error, dev sda, sector 31834343" messages.
> >
> > That's not exactly an expected result.  What makes you think it's due to
> > this patch?  Does 2.6.19-rc1-mm1 run OK?
> 
> Yes. (the only one issue is
> http://www.stardust.webpages.pl/files/tbf/euridica/2.6.19-rc1-mm1/mm-dmesg)
> 
> I get many "random" bugs that avoid hibernation with this patch.
> Unfortunately I can't catch backtraces (broken sysklogd, lack of
> serial console).
> 
> Here is the only one bug that I can reproduce and copy (by hand)
> 
> ---
> BUG: bad unlock balance detected!
> ---
> klogd/1751 is trying release lock (&cpu_base->lock_key) at:
> [<c0137a3d>] hrtimer_sched_tick
> but there are no more locks to release!
> other info that might help us debug this:
> 1 lock held by klogd/1751

<rewiews the patch again>

How completely bizarre.  I've no idea what's going on.  I'll see if I can
reproduce it later today (fat chance).

Meanwhile, let's blame Rusty.