From: Nick Piggin <npiggin@suse.de>
To: Robin Holt <holt@sgi.com>
Cc: Hugh Dickins <hugh@veritas.com>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get_user_pages(..., write==1, ...) may return with readable pte.
Date: Sun, 15 Oct 2006 10:03:51 +0200 [thread overview]
Message-ID: <20061015080351.GA4763@wotan.suse.de> (raw)
In-Reply-To: <20061014101507.GA6316@lnx-holt.americas.sgi.com>
On Sat, Oct 14, 2006 at 05:15:07AM -0500, Robin Holt wrote:
> > dup_mmap holds mmap_sem for write. get_user_pages caller must hold it
> > for read.
>
> I could have sworn I checked for that and found a down_read(), but
> now that I look when I have some time, it is clearly a down_write().
> Sorry for the distraction.
I'm one to do the same thing, don't worry ;)
> It is a user job that is passing data between hosts. The host is
> under heavy memory pressure and one rank of the MPI job gets silent
> data corruption.
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=016eb4a0ed06a3677d67a584da901f0e9a63c666
It could be this? inode reclaim calls invalidate_inode_pages, so this
one is a memory corrupter under heavy reclaim pressure.
>
> Thanks and sorry for wasting your time,
Not at all, my pleasure.
prev parent reply other threads:[~2006-10-15 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 20:33 Robin Holt
2006-10-14 4:53 ` Nick Piggin
2006-10-14 5:10 ` Nick Piggin
2006-10-14 10:15 ` Robin Holt
2006-10-15 8:03 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061015080351.GA4763@wotan.suse.de \
--to=npiggin@suse.de \
--cc=holt@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®