Re: [patch] cpu topology: consider sysfs_create_group return value

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Mon, 16 Oct 2006 09:31:26 +0200,
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> [patch] cpu topology: consider sysfs_create_group return value.
> 
> Take return value of sysfs_create_group() into account. That function got
> called in case of CPU_ONLINE notification. Since callbacks are not allowed
> to fail on CPU_ONLINE notification do the sysfs group creation on
> CPU_UP_PREPARE notification.
> Also remember if creation succeeded in a bitmask. So it's possible to know
> wether it's legal to call sysfs_remove_group or not.
> 
> In addition some other minor stuff:
> 
> - since CPU_UP_PREPARE might fail add CPU_UP_CANCELED handling as well.
> - use hotcpu_notifier instead of register_hotcpu_notifier.
> - #ifdef code that isn't needed in the !CONFIG_HOTPLUG_CPU case.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> 
>  drivers/base/topology.c |   56 +++++++++++++++++++++++++++---------------------
>  1 file changed, 32 insertions(+), 24 deletions(-)

Looks good.

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>