mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>, johnstul@us.ibm.com
Subject: Re: [PATCH] i386 Time: Avoid PIT SMP lockups
Date: Mon, 16 Oct 2006 11:39:37 -0700	[thread overview]
Message-ID: <20061016113937.a76f8d06.akpm@osdl.org> (raw)
In-Reply-To: <p73odsccqy5.fsf@verdi.suse.de>

On 16 Oct 2006 15:48:02 +0200
Andi Kleen <ak@suse.de> wrote:

> Andrew Morton <akpm@osdl.org> writes:
> > 
> > Is there any actual need to hold xtime_lock while doing the port IO?  I'd
> > have thought it would suffice to do
> > 
> > 	temp = port_io
> > 	write_seqlock(xtime_lock);
> > 	xtime = muck_with(temp);
> > 	write_sequnlock(xtime_lock);
> > 
> > ?
> 
> That would be a good idea in general. The trouble is just that whatever race
> is there will be still there then, just harder to trigger (so instead of 
> every third boot it will muck up every 6 weeks). Not sure that is
> a real improvement.
> 

Confused.  What race are you referring to?

This is addressing a starvation problem which is due to the slowness of the
port-io (iirc).


  reply	other threads:[~2006-10-16 18:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-11 19:54 john stultz
2006-10-11 21:26 ` Andrew Morton
2006-10-11 22:48   ` john stultz
2006-10-11 23:03     ` Andrew Morton
2006-10-16 13:48       ` Andi Kleen
2006-10-16 18:39         ` Andrew Morton [this message]
2006-10-16 18:42           ` Andi Kleen
2006-10-16 19:09             ` john stultz
2006-10-18 16:16   ` Maciej W. Rozycki
2006-10-18 16:27     ` Andi Kleen
2006-10-18 16:45       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061016113937.a76f8d06.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@suse.de \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®