From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Andi Kleen <ak@muc.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: x86-32/64 switch to pci_get API
Date: Mon, 16 Oct 2006 19:23:41 +0200 [thread overview]
Message-ID: <20061016172341.GB5385@rhun.haifa.ibm.com> (raw)
In-Reply-To: <20061016160759.GA14354@muc.de>
On Mon, Oct 16, 2006 at 06:07:59PM +0200, Andi Kleen wrote:
> > --- linux.vanilla-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c 2006-10-13 15:10:06.000000000 +0100
> > +++ linux-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c 2006-10-13 17:14:40.000000000 +0100
> > @@ -879,7 +879,7 @@
> >
> > error:
> > do {
> > - dev = pci_find_device_reverse(PCI_VENDOR_ID_IBM,
> > + dev = pci_get_device_reverse(PCI_VENDOR_ID_IBM,
> > PCI_DEVICE_ID_IBM_CALGARY,
> > dev);
>
> No put call anywhere?
The put is implicit in the call, since for each dev returned from
pci_get_device_reverse() we then call it with the same dev as the last
('from') parameter. We take a reference to dev elsewhere, just before
we start using it.
In any case these bridges can't be hot-plugged, so as long as the ref
count remains positive, we're fine.
Cheers,
Muli
prev parent reply other threads:[~2006-10-16 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 15:51 Alan Cox
2006-10-16 15:34 ` Muli Ben-Yehuda
2006-10-16 16:07 ` Andi Kleen
2006-10-16 16:45 ` Alan Cox
2006-10-16 16:24 ` Andi Kleen
2006-10-16 17:05 ` Alan Cox
2006-10-16 19:01 ` Andi Kleen
2006-10-16 20:52 ` Muli Ben-Yehuda
2006-10-16 21:18 ` Alan Cox
2006-10-16 17:23 ` Muli Ben-Yehuda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061016172341.GB5385@rhun.haifa.ibm.com \
--to=muli@il.ibm.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®